Skip to content

Ui redesign#110

Open
rin-st wants to merge 5 commits into
mainfrom
remove-rounded
Open

Ui redesign#110
rin-st wants to merge 5 commits into
mainfrom
remove-rounded

Conversation

@rin-st
Copy link
Copy Markdown
Member

@rin-st rin-st commented May 29, 2026

Most changes are just making borders square

Example of how component looks after update

Screenshot 2026-05-29 at 18 10 02

How to test with se-2 scaffold-eth/scaffold-eth-2#1282 (comment)

@rin-st rin-st requested review from carletex and technophile-04 May 29, 2026 14:23
@vercel
Copy link
Copy Markdown

vercel Bot commented May 29, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
scaffold-ui-docs Ready Ready Preview, Comment Jun 8, 2026 7:34am
scaffold-ui-example Ready Ready Preview, Comment Jun 8, 2026 7:34am

Request Review

@technophile-04
Copy link
Copy Markdown
Contributor

Did a pass on the square redesign with Claude code and direction looks great. Found a few rounded leftovers the sweep missed, plus one CSS-level radius that a class search wouldn't catch. Grouping them here so it's one fixup commit:

@sacffold-ui/componets:

CSS-level radius (class sweep can't see this one):

  • .sui-skeleton has border-radius: 0.2rem baked in, so every skeleton stays rounded even after the rounded-* classes were stripped (e.g. the avatar skeletons in Address.tsx). Needs to be set to 0 here:
    border-radius: 0.2rem;

Example app (lower stakes, but it contradicts the squared components):

Unrelated, but while you're in there — the loading spinner width fix uses var(--size-selector, 0.25rem), but --size-selector isn't defined anywhere in the repo, so it always falls back to 0.25rem. Looks copied from daisyUI. Probably cleaner as a plain 1.5rem (or calc(0.25rem * 6)):

width: calc(var(--size-selector, 0.25rem) * 6);

@rin-st
Copy link
Copy Markdown
Member Author

rin-st commented Jun 8, 2026

Ooops, I fixed all the issues 5 days ago but for some reason forgot to sent the message or something went wrong when I sent it. Ready to re-review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants